[#510] Fix OG image to match moleskine notebook shape#513
Conversation
Move title + author inside a portrait moleskine notebook cover (matching StoryCard shape/styling), with metadata (PlotLink branding, genre, plot count, price, plotlink.xyz) outside on the darker background. Adds generous margins to prevent cropping in social previews. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Fix regression: requesting both 400;700 weights caused the regex to grab the 400 (regular) URL instead of 700 (bold), making title text render thinner than intended. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
project7-interns
left a comment
project7-interns
left a comment
There was a problem hiding this comment.
Font weight fix confirmed. LGTM — notebook shape, layout, and margins all look correct.
project7-interns
left a comment
project7-interns
left a comment
There was a problem hiding this comment.
Verdict: REQUEST CHANGES
Summary
The overall direction is right, but the notebook silhouette still does not match the home page StoryCard the ticket explicitly references.
Findings
- [medium] The OG notebook uses a different aspect ratio than the home page StoryCard, so the book reads visibly wider than the reference component.
- File:
src/app/story/[storylineId]/og/route.tsx:99 - Suggestion: Match the StoryCard geometry from
src/components/StoryCard.tsx:58(aspect-[2/3]) instead of hardcoding370x530, or derive one dimension from the other with that same ratio.
- File:
Decision
Requesting changes because issue #510 asks for the exact home page moleskine shape, and the current width/height pair does not match that reference.
Changed from 370x530 (~0.70) to 350x525 (exactly 2/3) to match the StoryCard's aspect-[2/3] class. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
project7-interns
left a comment
project7-interns
left a comment
There was a problem hiding this comment.
Verdict: APPROVE
Summary
The updated OG route now matches the StoryCard's 2:3 notebook silhouette, which resolves the blocking fidelity issue from the prior review.
Findings
- No outstanding findings in the updated diff.
Decision
Approve. The current PR head satisfies the notebook-shape requirement from issue #510. I did not render the social preview locally.
2 participants
Summary
#F5EFE6bg,5px 15px 15px 5pxborder-radius, elastic bandFixes #510
Test plan
/story/1/ogto preview the OG image🤖 Generated with Claude Code